Warn on potential data races

spcl / dace

DaCe - Data Centric Parallel Programming

http://dace.is/fast

BSD 3-Clause "New" or "Revised" License

496 stars 130 forks source link

Warn on potential data races #1541

Closed luca-patrignani closed 4 months ago

luca-patrignani commented 8 months ago

This PR aims to raise a warning if two or more memlets are writing to the same access node and their ranges are overlapping. It also adds a new config entry to activate this check. This PR tries to close issue #424.

Needs confirmation:

[ ] Are the new tests overcomplicated?
[ ] Do we need some unit tests for are_intersecting?

luca-patrignani commented 8 months ago

@tbennun when you got some free time can you review this? Thanks

luca-patrignani commented 7 months ago

@tbennun when I got some free time can you review the last changes? I left a reply on your last comment.

phschaad commented 5 months ago

Pinging @tbennun , I assume this was burried

tbennun commented 4 days ago

@luca-patrignani @phschaad if possible, can we revive this so we can merge it? Thanks!

phschaad commented 4 days ago

@tbennun The PR is revived in https://github.com/spcl/dace/pull/1712 :)