search

spcl / dace

DaCe - Data Centric Parallel Programming
http://dace.is/fast
BSD 3-Clause "New" or "Revised" License
496 stars 129 forks source link

Made `dace::math::pow` forward to `std::pow` more generic #1583

Closed BenWeber42 closed 4 months ago

BenWeber42 commented 5 months ago

This overload solution will forward the argument types separately and use the same return type.

BenWeber42 commented 5 months ago

My attempt at combining https://github.com/spcl/dace/pull/1582 and https://github.com/spcl/dace/pull/1521.

Berke-Ates commented 4 months ago

Thanks for the work! Looks good to me!

BenWeber42 commented 4 months ago

I want to separate the Xilinx Vitis HLS compiler flag change into its own PR: https://github.com/spcl/dace/pull/1585 If we can merge that PR, I will remove the change in this PR. Then it should be ready for review.

philip-paul-mueller commented 4 months ago

LGTM