spcl / dace

DaCe - Data Centric Parallel Programming
http://dace.is/fast
BSD 3-Clause "New" or "Revised" License
491 stars 127 forks source link

Rename misleading topological_sort to bfs_nodes #1590

Closed BenWeber42 closed 3 months ago

BenWeber42 commented 4 months ago

This is currently work in progress to see how we can best fix this misleading naming.

Fixes https://github.com/spcl/dace/issues/1560

Since https://github.com/spcl/dace/issues/1560 is still in flux, we have to make sure the PR stays in sync with what we are discussing in https://github.com/spcl/dace/issues/1560.

Additionally, at the call-sites of the _previous topologicalsort (before renaming), there are various comments to use a topoligical sort. After the renaming, they become misleading, so we should probably fix/improve those comments.