spcl / daceml

A Data-Centric Compiler for Machine Learning
https://daceml.readthedocs.io
BSD 3-Clause "New" or "Revised" License
81 stars 14 forks source link

Fix gpu scalar issues #38

Closed orausch closed 3 years ago

orausch commented 3 years ago

Now that dace has been updated to handle scalars differently, we can fix #20 and #21.

codecov[bot] commented 3 years ago

Codecov Report

Merging #38 (235e867) into master (dee594e) will decrease coverage by 7.78%. The diff coverage is 93.23%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #38      +/-   ##
==========================================
- Coverage   94.44%   86.66%   -7.78%     
==========================================
  Files          22       32      +10     
  Lines        1584     2497     +913     
==========================================
+ Hits         1496     2164     +668     
- Misses         88      333     +245     
Impacted Files Coverage Δ
daceml/onnx/schema.py 94.44% <ø> (ø)
daceml/util/utils.py 84.85% <68.75%> (-15.15%) :arrow_down:
daceml/transformation/constant_folding.py 89.04% <71.43%> (-6.86%) :arrow_down:
daceml/autodiff/implementations/onnx_ops.py 81.25% <81.25%> (ø)
...ml/onnx/op_implementations/pure_implementations.py 83.54% <87.27%> (+0.08%) :arrow_up:
daceml/autodiff/pytorch.py 94.12% <94.12%> (ø)
daceml/autodiff/backward_pass_generator.py 95.49% <95.49%> (ø)
daceml/autodiff/utils.py 96.97% <96.97%> (ø)
daceml/autodiff/base_abc.py 97.14% <97.14%> (ø)
daceml/autodiff/implementations/dace_nodes.py 97.56% <97.56%> (ø)
... and 26 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update dee594e...239a441. Read the comment docs.

orausch commented 3 years ago

Fixed in #42