spcl / daceml

A Data-Centric Compiler for Machine Learning
https://daceml.readthedocs.io
BSD 3-Clause "New" or "Revised" License
82 stars 15 forks source link

FPGA Convolution (Im2col with aligned vectors and tiling) #79

Closed manuelburger closed 3 years ago

manuelburger commented 3 years ago

Im2Col Convolution Implementation:

Xilinx:

codecov[bot] commented 3 years ago

Codecov Report

Merging #79 (264ad0c) into master (c2133c6) will increase coverage by 0.19%. The diff coverage is 91.76%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #79      +/-   ##
==========================================
+ Coverage   87.95%   88.14%   +0.19%     
==========================================
  Files          51       51              
  Lines        5312     5590     +278     
==========================================
+ Hits         4672     4927     +255     
- Misses        640      663      +23     
Impacted Files Coverage Δ
...ml/onnx/op_implementations/fpga_implementations.py 90.59% <91.58%> (+0.33%) :arrow_up:
daceml/onnx/nodes/onnx_op.py 94.24% <100.00%> (ø)
daceml/util/utils.py 91.74% <100.00%> (+0.36%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c2133c6...264ad0c. Read the comment docs.

manuelburger commented 3 years ago

The CPU-CI failed due to test_training.py::test_bert[False]. This code is not at all related with that test. Also, that test passed for commit 55cd162 and fails now for commit 65df2ac, although nothing that has changed, should have an effect. Either the CI has some issues or there is a race condition in the training/bert code, I would guess.