spcl / daceml

A Data-Centric Compiler for Machine Learning
https://daceml.readthedocs.io
BSD 3-Clause "New" or "Revised" License
81 stars 14 forks source link

[FPGA] Add example script for VGG Convolutions #80

Closed manuelburger closed 3 years ago

manuelburger commented 3 years ago

Adds example script for running the convolutional part of the VGG16 architecture on FPGA in the fpga test directory.

codecov[bot] commented 3 years ago

Codecov Report

Merging #80 (a0d68ad) into master (9651a28) will decrease coverage by 0.06%. The diff coverage is 20.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #80      +/-   ##
==========================================
- Coverage   88.23%   88.17%   -0.06%     
==========================================
  Files          51       51              
  Lines        5624     5629       +5     
==========================================
+ Hits         4962     4963       +1     
- Misses        662      666       +4     
Impacted Files Coverage Δ
daceml/util/utils.py 88.89% <20.00%> (-2.85%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9651a28...a0d68ad. Read the comment docs.

orausch commented 3 years ago

You could also consider adding it as an example script to the documentation: https://daceml.readthedocs.io/en/latest/auto_examples/index.html

I think the docs build is currently broken, but I'll fix that soon.

manuelburger commented 3 years ago

You could also consider adding it as an example script to the documentation: https://daceml.readthedocs.io/en/latest/auto_examples/index.html

I think the docs build is currently broken, but I'll fix that soon.

I could yes. The current location was just where a similar example script for LeNet is and also all other FPGA related material, so that was the reason for me putting it there. @TizianoDeMatteis any preferences?

TizianoDeMatteis commented 3 years ago

You could also consider adding it as an example script to the documentation: https://daceml.readthedocs.io/en/latest/auto_examples/index.html I think the docs build is currently broken, but I'll fix that soon.

I could yes. The current location was just where a similar example script for LeNet is and also all other FPGA related material, so that was the reason for me putting it there. @TizianoDeMatteis any preferences?

@orausch Since this is not the full VGG (normalization is missing) I will keep it there and move it to the example later. Is this ok for you?

orausch commented 3 years ago

Sure