search

spcl / faaskeeper

A fully serverless implementation of the ZooKeeper coordination protocol.
BSD 3-Clause "New" or "Revised" License
16 stars 13 forks source link

issue #20 CLI operations improved #33

Closed shailendrasingh117 closed 8 months ago

shailendrasingh117 commented 1 year ago

20 So the main issue was:

  1. Support for create operation:
    The writer function has been extended to include options for ephemeral and sequential nodes.
  2. Bug when socket is closed by write function:
    The updated code now includes error handling for handling the case when the socket is closed by the write function.

Issues Resolved.

mcopik commented 1 year ago

@shailendrasingh117 I'm confused - the code in the PR replaces the existing implementation, does not implement any handling of arguments, and it's very different from what has been posted in issue #20. Furthermore, you mentioned fixing a bug for socket closure - this one is also missing.

mcopik commented 8 months ago

This PR will be closed due to a lack of responses to the code review and no activity.

If you want to continue working on this issue, please feel free to push changes and reopen it :)