search

spcl / graph-of-thoughts

Official Implementation of "Graph of Thoughts: Solving Elaborate Problems with Large Language Models"
https://arxiv.org/pdf/2308.09687.pdf
Other
2.19k stars 159 forks source link

Possible error in `got` method for `doc_merge.py` #9

Closed tonyzhao6 closed 1 year ago

tonyzhao6 commented 1 year ago

https://github.com/spcl/graph-of-thoughts/blob/f6be6c06f22728afd22b2a19eca1cfa27010dcf0/examples/doc_merge/doc_merge.py#L223C45-L223C45

In the line above, if current is either None or an empty string, should the string formatting be num=len(documents) instead?

nblach commented 1 year ago

Thank you, great catch! You are correct that it should be num=len(documents) for the got approach, but not for the got2 approach.