Add dependency on read-writer queue

spcl / rFaaS

rFaaS: a high-performance FaaS platform with RDMA acceleration for low-latency invocations.

https://mcopik.github.io/projects/rfaas/

BSD 3-Clause "New" or "Revised" License

49 stars 15 forks source link

Add dependency on read-writer queue #14

Open mcopik opened 2 years ago

mcopik commented 2 years ago

We should add readerwriterqueue as a proper dependency in the CMake build. Furthermore, we want to fetch and build Pistache to avoid the trouble of forcing users to install it manually.

[ ] Fetch the dependency with CMake.
[ ] Ensure that include directories are properly configured.
[ ] Add in the README proper acknowledgment of the other project.

Yuanmxc commented 1 year ago

I'll try to file a pr for this, but I'm wondering how to handle versioning of the library

mcopik commented 1 year ago

@Origin-yy I think we can fetch the tag corresponding to the lastest release. You can also compare it against the version we included in our code to check if there are any potential incompatibilities.

Mac16661 commented 1 year ago

I am new to open source development, but I'm eager to learn and contribute to resolving this issue.

mcopik commented 1 year ago

@Mac16661 I recommend starting with looking at CMake FetchModule - we want to use that to add the library as a component :-)