search

spcl / serverless-benchmarks

SeBS: serverless benchmarking suite for automatic performance analysis of FaaS platforms.
https://mcopik.github.io/projects/sebs/
BSD 3-Clause "New" or "Revised" License
150 stars 68 forks source link

Container support for AWS #205

Closed prajinkhadka closed 2 weeks ago

prajinkhadka commented 5 months ago

Added Support for container deployment in AWS.

Summary by CodeRabbit

Release Notes

prajinkhadka commented 5 months ago

Very nice progress! I left some comments.

The important issues are:

* CLI option and documentation

* Testing Node.js

* Moving resource allocation to proper resource classes.

* Checking the "update" of container-based function on AWS.

* Regression testing

Hi, Marcin, I have reviewed the changes. Also, I performed the regression tests for both Node.js and Python. I also added the logic to Fail early if container deployment flag is set as True for other than AWS.

regressionlogs_nodejs.txt regressionlogs_python.txt

mcopik commented 4 months ago

@coderabbitai review

coderabbitai[bot] commented 4 months ago
Actions performed Review triggered. > Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.
coderabbitai[bot] commented 4 months ago

[!CAUTION]

Review failed

The pull request is closed.

Walkthrough

This pull request introduces a variety of changes across multiple files to enhance support for containerized deployment in serverless benchmarks. Key modifications include the addition of a new setup script for a Python package, updates to configuration files to reflect AWS deployment settings, and enhancements to Dockerfiles for both Python and Node.js functions. Additionally, several classes and methods across the codebase have been updated to accommodate new parameters related to container deployment, improving the functionality and flexibility of the deployment process.

Changes

File Path Change Summary
benchmarks/wrappers/aws/python/setup.py New setup script added for Python package, specifying dependencies and package structure.
config/example.json Updated deployment settings from "openwhisk" to "aws", changed runtime from "nodejs" to "python" 3.8, added "container_deployment" field.
config/systems.json Added "container_deployment" key, updated deployment files for AWS Python, included new package dependency for Node.js.
dockerfiles/aws/nodejs/Dockerfile.function New Dockerfile for Node.js function, includes build argument for base image and sets up function handler.
dockerfiles/aws/python/Dockerfile.function New Dockerfile for Python function, includes conditional installation of dependencies based on version.
docs/modularity.md Updated documentation for clarity on adding benchmarks and extending the SeBS framework.
docs/usage.md Added --container-deployment flag to CLI documentation and refined local deployment instructions.
requirements.aws.txt Updated boto3-stubs to include ecr support.
requirements.txt Added rich package for terminal formatting.
sebs.py Enhanced CLI with new --container-deployment option, updated function signatures to include new parameters.
sebs/aws/aws.py Updated methods for Docker image management and Lambda function creation, added new methods for ECR interactions.
sebs/aws/config.py Enhanced AWSResources class with Docker registry management methods and properties.
sebs/azure/azure.py Updated methods to handle container deployments, added error handling for unsupported features.
sebs/benchmark.py Added properties for managing container-related information.
sebs/cache.py Updated methods to include container_uri for code package management.
sebs/config.py Added method for retrieving supported container deployment options.
sebs/experiments/config.py Introduced _container_deployment attribute for configuration management.
sebs/experiments/invocation_overhead.py Updated before_sample method to include new parameters for function updates.
sebs/faas/system.py Enhanced methods for packaging and creating functions with container deployment support.
sebs/gcp/gcp.py Updated methods to accommodate container deployment parameters.
sebs/local/local.py Enhanced methods to manage container deployment parameters.
sebs/openwhisk/openwhisk.py Updated methods for Docker image management and function creation with container deployment parameters.
sebs/sebs.py Modified get_deployment method to validate container deployment configuration.

Possibly related issues

Possibly related PRs

🐰 In a world of clouds and code,
Where functions hop and data flowed,
We build with care, with Docker's might,
Container dreams take joyful flight!
So let us cheer, with paws so spry,
For benchmarks soar, oh me, oh my! 🐇

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
🪧 Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
mcopik commented 2 weeks ago

Remaining issues: