search

spdegabrielle / table-panel

This library provides a table-panel% class that specializes the panel% class to provide a panel that aligns its children to a grid. A simple demonstration program is also provided. Copyright(c) 2008, M. Douglas Williams.
GNU Lesser General Public License v2.1
4 stars 0 forks source link

Mismatched documentation/code for set-dimensions #2

Open dwmuller opened 6 years ago

dwmuller commented 6 years ago

The documentation describes set-dimensions as taking n-rows, then n-cols, but the code actually expects n-cols, then n-rows.

The documented order is consistent with other usages. Unfortunately, fixing the code to match the documentation will be a breaking change.

spdegabrielle commented 5 years ago

apologies @dwmuller I only just saw this.

spdegabrielle commented 5 years ago

On thinking I think it is better to change the documentation.

dwmuller commented 5 years ago

Yeah, the inconsistency is unfortunate, but it's probably better not to break existing code.