spdomin / Nalu

Deprecated to NaluCFD/Nalu or ExaWind/Nalu-Wind. See LICENSE for more information.
Other
28 stars 11 forks source link

Turbulence averaging interface may not support multiple specifications #35

Closed spdomin closed 8 years ago

spdomin commented 8 years ago

Working through the DataProbes interface has exposed (possibly) an issue with multiple specifications for turbulence averaging.

spdomin commented 8 years ago

I reviewed the code. For every specification, a unique AveragingInfo object is created. This is sufficient to manage the end use case. The following is a typical example:

turbulence_averaging:
  time_filter_interval: 100000.0

  specifications:

    - name: one
      target_name: block_10
      reynolds_averaged_variables:
        - velocity
        - enthalpy
        - resolved_turbulent_ke

      favre_averaged_variables:
        - velocity
        - enthalpy
        - resolved_turbulent_ke

      compute_tke: yes 
      compute_reynolds_stress: yes

    - name: two
      target_name: surface_5
      reynolds_averaged_variables:
        - normal_heat_flux
      favre_averaged_variables:
        - normal_heat_flux

Closing with the note that perhaps the probe code is over-designed:)