search

spdx / LicenseListPublisher

Tool that generates license data found in the license-list-data repository from the license-list-XML source
Apache License 2.0
11 stars 18 forks source link

Improve contrast of the generated website #123

Closed seabass-labrax closed 2 years ago

seabass-labrax commented 2 years ago

This commit changes the colour of the text in the generated website from light blue to the dark blue of the SPDX logo, in order to meet Level AAA of the Web Content Accessibility Guidelines (WCAG) for contrast.

See also https://github.com/spdx/spdx-spec/pull/574, which made this change (and other contrast improvements) to the SPDX specification website.

goneall commented 2 years ago

@seabass-labrax Thanks for the PR!

Can you upload a screenshot with the new colors to make it easier to review?

I usually run these by @jlovejoy before making any changes to the SPDX license list website.

goneall commented 2 years ago

BTW - you can ignore the CI failure - it is a problem with how I setup the authentication tokens.

seabass-labrax commented 2 years ago

Screenshots coming up! :)

Before: spdx-license-list-website-before

After: spdx-license-list-website-after

goneall commented 2 years ago

Thanks @seabass-labrax

@jlovejoy - let me know if you're OK with these changes and I'll merge them in for the next license list release

goneall commented 2 years ago

Haven't heard back from @jlovejoy - but the changes look pretty safe and we should be meeting the accessibility standards - so going ahead and merging

seabass-labrax commented 2 years ago

Thanks for merging, Gary! :)