search

spdx / LicenseListPublisher

Tool that generates license data found in the license-list-data repository from the license-list-XML source
Apache License 2.0
11 stars 18 forks source link

Unneeded empty lines in license text for LGPL-3.0-only #61

Closed cordlandwehr closed 4 years ago

cordlandwehr commented 4 years ago

The license text for LGPL-3.0-only contains unneeded empty lines, which are actually not displayed in the HTML version of the license: https://github.com/spdx/license-list-data/blob/master/text/LGPL-3.0-or-later.txt For me it seems that line breaks from the LGPL-3.0 HTML page are considered by the conversion tool in the same way as

or
tags, which leads to the strange result.

This issue was originally reported in the reuse tracker, adding a link for cross-referencing the issue: https://github.com/fsfe/reuse-tool/issues/178

PalAditya commented 4 years ago

Hi, I was interested in taking up this issue as I am interested in SPDX and this seems beginner friendly. Am I right in assuming that all this PR is supposed to do is remove the empty lines (22ff, 33ff, 47ff) as mentioned in the original issue, or is there something more to it?

goneall commented 4 years ago

@PalAditya Thanks for looking into the issues - it turns out that these files are generated by LicenseListPublisher so any fix should be in the application.

goneall commented 4 years ago

Transferring this issue to the LicenseListPublisher.

goneall commented 4 years ago

Here's a link to the source license XML: https://github.com/spdx/license-list-XML/blob/master/src/LGPL-3.0-only.xml

I wonder if this is caused by the extra paragraph tags within the item tags.

I am considering this a bug in the generation tool since it renders correctly in HTML, but it could be argued we should fix the source XML to remove the paragraphs.

goneall commented 4 years ago

Resolved with PR #83