spdx / LicenseListPublisher

Tool that generates license data found in the license-list-data repository from the license-list-XML source
Apache License 2.0
11 stars 18 forks source link

Performance improvement - processing licenses twice #72

Closed goneall closed 3 years ago

goneall commented 4 years ago

The function writeExceptionList creates a list of licenseId's by re-parsing all the licenses which is quite expensive (see https://github.com/spdx/LicenseListPublisher/blob/f8cb27d6da741af0a926a7ba401b3450909c10e0/src/org/spdx/licenselistpublisher/LicenseRDFAGenerator.java#L356)

The list of license ID's is already collected in the writeLicenseList and can be passed into this method. This could improve performance by 30-40%.

goneall commented 3 years ago

Resolved in PR #82