search

spdx / LicenseListPublisher

Tool that generates license data found in the license-list-data repository from the license-list-XML source
Apache License 2.0
11 stars 18 forks source link

Text matching #74

Closed tjasmith closed 4 years ago

goneall commented 4 years ago

@tjasmith Could you also add a couple of unit tests?

goneall commented 4 years ago

@tjasmith I published the new version of the SPDX tools and tested out this PR. It seems to work well in matching the licenses 👍 There is one change I'd like you to make before merging - handling the exceptions by logging and returning false. Once that's done I'll go ahead and merge.

I also added 2 new issues which would be nice to have before using for the next license list publication: #76 #75 - let me know if you want to work on either of these.