search

spdx / Spdx-Java-Library

Java library which implements the Java object model for SPDX and provides useful helper functions
Apache License 2.0
32 stars 33 forks source link

Official GPL-1.0 license text is not being matched correctly by LicenseCompareHelper.isTextStandardLicense() #231

Open pmonks opened 3 months ago

pmonks commented 3 months ago

When org.spdx.utility.compare.LicenseCompareHelper.isTextStandardLicense().isDifferenceFound() is run on the official GPL-1.0 license text, it (incorrectly) returns true (i.e. the standard license was not matched). When I run org.spdx.utility.compare.LicenseCompareHelper.isTextStandardLicense().getDifferenceMessage() on it, I get:

Additional text found after the end of the expected license text starting at line #192 column #21 "end"

However the GPL-1.0 SPDX template does appear to (correctly) contain the text END OF TERMS AND CONDITIONS at this point (albeit in an <optional> block).

This was reproduced with Spdx-Java-Library v1.11 and SPDX license list v3.23.

pmonks commented 3 months ago

Note: the same thing appears to be happening with the official GPL-2.0 license text as well.