spdx / license-list-XML

This is the repository for the master files that comprise the SPDX License List
Other
344 stars 278 forks source link

New license request: NCL #2386

Closed nielsdg closed 5 months ago

nielsdg commented 8 months ago

1. License Name: FFTPACK License 2004 2. Short identifier: fftpack-2004 3. License Author or steward: Unknown 4. Comments: This license was discovered during license review in Fedora Linux. https://gitlab.com/fedora/legal/fedora-license-data/-/issues/475. It is used in the package pipewire.

The license is known to scancode-toolkit: https://github.com/nexB/scancode-toolkit/blob/develop/src/licensedcode/data/licenses/fftpack-2004.LICENSE 5. License Request Url: http://tools.spdx.org/app/license_requests/349 6. URL(s): https://gitlab.freedesktop.org/pipewire/pipewire/-/blob/master/src/modules/module-filter-chain/pffft.c?ref_type=heads#L1-52 7. OSI Status: Unknown 8. Example Projects: https://pipewire.org/

jlovejoy commented 7 months ago

this is very similar to BSD-3-Clause, except:

Given the above, I suspect we should add this as a new license

karsten-klein commented 7 months ago

ScanCode license id: fftpack-2004

{metæffekt} Universe canonical name: Spherepack License short name: Spherepack

Open CoDE Open CoDE status: approved Open CoDE approved license reference: LicenseRef-scancode-fftpack-2004

Comments Seems we detected that licenses in another context (Spherepack); see also https://sources.debian.org/src/spherepack/3.3~a1-5/debian/copyright/. To consolidate naming I would conclude either a

jlovejoy commented 7 months ago

interesting, so the license in link for the submission seems to got to piperwire project, and then it calls it the "FFTPACK license" in the file. Has the same 2004 copyright notice as what @karsten-klein found in Debian seems to inicate the file is part of spherepack.

Doing a Google search on a phrase, turns up a few other places, but notably: https://www.ncl.ucar.edu/Download/NCL_source_license.shtml

So, I think @karsten-klein idea as to using UCAR or NCAR in the name makes the most sense to me. Note that UCAR is essentially the umbrella organization under which NCAR sits (and happens to be located in my home town in a prominent location on a mesa below the flatiron rock formations and in a building of sandstone designed by the famous I.M Pei... but I digress...)

We do have a UCAR License already on the list - https://spdx.org/licenses/UCAR.html

Perhaps we could go with "NCL Source Code License" and "NCL" since that is the title on this page https://www.ncl.ucar.edu/Download/NCL_source_license.shtml I would note that the license text there is slightly different than in FFTPACk in that "of the Software" is omitted at the above link, whereas it is in the license text in the FFTPACK link: "Redistribution and use of the Software in source and binary forms"

An alternative might be NCAR-CISL ?

I'd hesitate to use only NCAR as it seems likely we may see other licenses from UCAR/NCAR

nielsdg commented 7 months ago

@wtay : I don't know how well you remember the licensing of the file you copied in Pipewire here, but do you have some thoughts on it?

swinslow commented 6 months ago

@jlovejoy Given that the "NCL Source Code License" at https://www.ncl.ucar.edu/Download/NCL_source_license.shtml doesn't match exactly (e.g. doesn't have "of the Software" as you mentioned), I'm not sure we want to reference that for the ID / name.

Is there a reason not to just go with FFTPACK as ID and "FFTPACK License" as name, since that's how we see it being referred to in the wild?

Pizza-Ria commented 6 months ago

@swinslow "NCL Source Code License" at https://www.ncl.ucar.edu/Download/NCL_source_license.shtml is an awful lot closer than the original issues @jlovejoy brought up for BSD-3. But I'm not sure if NCL-UCAR has an SPDX ID already?

Pizza-Ria commented 6 months ago
swinslow commented 6 months ago

Discussed on 2024-03-28 Legal team call, agreed to add, ID as NCL and name as "NCL Source Code License". Should include markup to handle FFTPACK changes per @Pizza-Ria's comment immediately above.

jlovejoy commented 6 months ago

License Inclusion Decision

Decision:

Name

NCL Source Code License

License ID

NCL

XML markup

yes, see comments above

Notes:

none

Next steps

If the license has been accepted, please follow the accepted-license process to create the PR.

github-actions[bot] commented 5 months ago

This new license/exception request has been accepted and the information for the license/exception has been merged to the repository. Thank you to everyone who has participated! The license/exception will be published at https://spdx.org/licenses/ as part of the next SPDX License List release, which is expected to be in three months' time or sooner. In the interim, the new license will appear on the license list preview site at https://spdx.github.io/license-list-data/. This is an automated message.