search

spdx / license-list-XML

This is the repository for the master files that comprise the SPDX License List
Other
355 stars 288 forks source link

markup change to MIT-Khronos-old #2496

Open xsuchy opened 5 months ago

xsuchy commented 5 months ago

In the review in #2017 it was said that this paragraph: This text may be omittable (B.3.5 Guideline: omittable text), as it is merely informative or explanatory, not any right grant or restriction.

but the optional tags were not added in the initial commit. Adding now.

swinslow commented 3 months ago

Hi @xsuchy, thanks for this.

I'm not sure I agree with that conclusion from the reviewer of the issue originally. I think they were proposing to make that optional in the course of deciding whether it could be considered a match for standard MIT (which we decided it wasn't, hence the new ID).

If we make that paragraph optional, then I think the only differences between this and the standard MIT license would be using "Materials" instead of "Software as the defined term; and an "and/or" instead of "and" in the first sentence.

Just to ask, though, are you seeing any instances of the MIT-Khronos-old text appearing without that central paragraph? Put another way, are there examples you're encountering where making this paragraph optional would cause it to match a license text you've seen?

xsuchy commented 3 months ago

Just to ask, though, are you seeing any instances of the MIT-Khronos-old text appearing without that central paragraph?

Yes. https://sourceforge.net/p/mingw-w64/mingw-w64/ci/master/tree/mingw-w64-headers/include/GL/glext.h

swinslow commented 3 months ago

Got it, thanks @xsuchy!

@jlovejoy So this is a tricky one. It is either (1) very close to standard MIT, except with "Materials" instead of "Software" and a couple of other very minor changes:

image

...or (2) very close to MIT-Khronos-old, but without the central paragraph:

image

Do you have a preference for how to handle this? I'd lean towards minor markup to MIT as I think that's substantively closer rather than making the central paragraph optional for the Khronos variant, but I could be persuaded either way.

xsuchy commented 1 month ago

Gentle ping @jlovejoy

pombredanne commented 1 month ago

FWIW, we have tracked this MIT variant without the extra paragraph as a separate license for about 10 years: https://github.com/aboutcode-org/scancode-toolkit/blob/develop/src/licensedcode/data/licenses/khronos.LICENSE