search

spdx / license-list-XML

This is the repository for the master files that comprise the SPDX License List
Other
355 stars 288 forks source link

Update Mackerras-3-Clause-acknowledgment.xml #2605

Closed coky-t closed 2 weeks ago

coky-t commented 2 weeks ago

The current email address is listed from ppp-2.5.1 onwards, but the email address in the license is different up to ppp-2.5.0.

https://github.com/ppp-project/ppp/blob/ppp-2.5.1/pppd/auth.c#L20: paulus@ozlabs.org

https://github.com/ppp-project/ppp/blob/ppp-2.5.0/pppd/auth.c#L20: paulus@samba.org

xsuchy commented 2 weeks ago

Can you make the regexp smaller?

&lt;<alt match="(paulus@ozlabs.org|paulus@samba.org)&gt;"

Or even provide alt just for the domain name after @.

xsuchy commented 2 weeks ago

Test suite fails with

    Test for license Mackerras-3-Clause-acknowledgment failed: Test for license ID 
Mackerras-3-Clause-acknowledgment failed due to difference found Normal text of license
does not match starting at
line #17 column #17 "." when comparing to template text " Redistributions of any form whatsoever must retain the following acknowledgment: "This product incl..."
xsuchy commented 2 weeks ago

Hmm, I do not see what is the problem.

xsuchy commented 2 weeks ago

Thank you for trying. I see that putting lt/gt outside of regexp somehome breaks test. So I do not mind now having it inside. Despite that it results in longer formula.