search

spdx / ntia-conformance-checker

Check SPDX SBOM for NTIA minimum elements
Apache License 2.0
52 stars 19 forks source link

Fix file argument #154

Closed starswaterbrook closed 1 year ago

starswaterbrook commented 1 year ago

This fix should allow omitting --file argument (prints the help message if so), while still allowing to pass arguments like --verbose or --version without crashing.

jspeed-meyers commented 1 year ago

Thank you, @mwkm00!

jspeed-meyers commented 1 year ago

@mwkm00, it looks like the black formatting linter is failing.

More info on black is here: https://github.com/psf/black

Would you mind fixing that before I review this?

starswaterbrook commented 1 year ago

Should be good now, I assumed exit code 1 would be acceptable after not delivering file arg, but the program goes to the help message and exits gracefully so exit code 0 is probably the way to go. Tests should be fixed now.

jspeed-meyers commented 1 year ago

But the black linter is still failing. hmmm 🤔

starswaterbrook commented 1 year ago

My bad, formatting. Thanks for patience.

jspeed-meyers commented 1 year ago

@vargenau, is that you were thinking?

vargenau commented 1 year ago

Hi,

Yes, it works correctly now.

Thank you for the quick fix.

jspeed-meyers commented 1 year ago

@goneall, would you please take a quick look too? 🙏