search

spdx / ntia-conformance-checker

Check SPDX SBOM for NTIA minimum elements
Apache License 2.0
47 stars 18 forks source link

Provide more information in get_components_without_* functions #169

Closed CsatariGergely closed 6 months ago

CsatariGergely commented 6 months ago

Optionally return both the name and the SPDXID of problematic elements in get_componentswithout* functions.

Closes #168

CsatariGergely commented 6 months ago

One thing what I could not decide if should all the get_components_without_* functions have the returnTuples option? get_components_without_names would add None to the name while get_components_without_identifiers would add None to the SPDXID. I was not able to create tests to test get_components_without_identifiers.

CsatariGergely commented 6 months ago

Thank you for this PR. Two small nits: the CI is failing because of a formatting issue and a lint issue. Can you please fix those? black is the formatter this project uses. pylint is the linter this project uses.

I've fixed these in dc3c53d. Maybe black and pylint could be mentioned in CONTRIBUTING.md just to avoid extra GitHub Action cycles.

jspeed-meyers commented 6 months ago

Maybe black and pylint could be mentioned in CONTRIBUTING.md just to avoid extra GitHub Action cycles.

Yes, definitely. Good call. Issue created: https://github.com/spdx/ntia-conformance-checker/issues/170

jspeed-meyers commented 6 months ago

@goneall: Can you please take a look too when you have a moment? Thank you!