search

spdx / sbom-landscape

SPDX SBOM Landscape
https://landscape.spdx.dev
Apache License 2.0
15 stars 10 forks source link

First commit to landscape.yml #29

Closed MordodeMaru closed 1 year ago

MordodeMaru commented 1 year ago

Please review this first commit to see if it's in line with what is expected. This project did not have an SVG image of its logo so I created one with an online converter that actually hosts the new SVG file. Please let me know otherwise.

I've left the Crunchbase link section empty because Augur Labs doesn't have a Crunchbase profile.

Pre-submission checklist:

Please check each of these after submitting your pull request:

MordodeMaru commented 1 year ago

@tracymiranda @kestewart if you could check this I'll proceed with the rest when I have time.

tracymiranda commented 1 year ago

Although the logs seem to complain about the github repo, I'm inclined to think the issue here is the logo. I'm not sure it will work referenced from the gdrive link - could we try checking in the svg to the 'hosted logos' folder and then referencing it by name.

MordodeMaru commented 1 year ago

I've tried adding a new file to that folder, @tracymiranda but it seems i need permissions? Or should I rather create a new one? I don't know how the latter would work.

Screenshot 2023-06-20 at 17 29 02 Screenshot 2023-06-20 at 17 27 45
tracymiranda commented 1 year ago

You can't commit directly to the main repo, you have to add the file to your fork/branch where you made the other changes. @MordodeMaru

MordodeMaru commented 1 year ago

I believe my patch should now include the changes to the logo folder where I have uploaded Augur's logo in SVG format.

Can you confirm, @tracymiranda that I did right this time?

tracymiranda commented 1 year ago

Hmm the build still failed - this time complaining about the repo: https://github.com/chaoss/augur/. The repo exists so not sure why this is an issue @AndreyKozlov1984 wonder if any ideas?

tracymiranda commented 1 year ago

@MordodeMaru looks like you just need to remove the trailing slash from https://github.com/chaoss/augur/ and we should be good to go

MordodeMaru commented 1 year ago

Done.

tracymiranda commented 1 year ago

Spoke too soon, looks like there are 2 failing issues in the logs:

6:31:04 AM: FATAL: We do not support urls for images anymore. Please download the image and put it into the hosted_logos folder, then put its name to the logo field 6:31:06 AM: FATAL: Augur either has no crunchbase entry or it is invalid

MordodeMaru commented 1 year ago

I don't understand. The logo is in fact in the hosted_logos folder, see below. I don't what to do about the crunchbase entry. I've left it empty because, well, there isn't one. What should I have done? @kestewart CleanShot 2023-08-03 at 16 37 04

tracymiranda commented 1 year ago

Yes but you need to update the logo field so it isn't pointing to the drive anymore but has the name of the svg file. Also looks like a crunchbase entry is required

MordodeMaru commented 1 year ago

With the help of Andrey Kozlov from the CNCF I think I amended the two things that were wrong. 🤞🏻

MordodeMaru commented 1 year ago

So the logo I was trying to push was empty god knows why. I am faily sure I did it right but hey, who am I to argue with Git. Having said that, I deleted the empty logo and now I think that the only solution is to close this PR, open again a fork and push it back this time with the logo in it properly.

MordodeMaru commented 1 year ago

I am completely lost as what is failing now, @kestewart @tracymiranda. I have sought help in the CNCF's slack community but I think I ran out of luck.

tracymiranda commented 1 year ago

I think the plan to close this PR is good. I see the new one with the logo has succeeded.