Closed goneall closed 1 year ago
Some of the Lift findings in this PR can be automatically fixed. You can download and apply these changes in your local project directory of your branch to review the suggestions before committing.[^1]
# Download the patch
curl https://lift.sonatype.com/api/patch/github.com/spdx/spdx-java-tagvalue-store/35.diff -o lift-autofixes.diff
# Apply the patch with git
git apply lift-autofixes.diff
# Review the changes
git diff
Want it all in a single command? Open a terminal in your project's directory and copy and paste the following command:
curl https://lift.sonatype.com/api/patch/github.com/spdx/spdx-java-tagvalue-store/35.diff | git apply
Once you're satisfied commit and push your changes in your project. [^1]: You can preview the patch by opening the patch URL in the browser.
Fixes #34
Also includes some minor performance improvements Sorting does degrade the performance by about 40% on the optimized code. However, it is still reasonably fast at >28,000 lines per second on my machine.