spdx / spdx-license-diff

Chrome/Firefox browser extension to compare text against spdx license list
GNU General Public License v3.0
33 stars 6 forks source link

Chrome extension: Manifest V3 transition #122

Open RogueScholar opened 2 months ago

RogueScholar commented 2 months ago

Already a few months into the Manifest V2 soft deprecation period and I'll admit it's troubling¹ to see this extension always at the top of my Chrome Extensions page accompanied by the ambiguous warning that it will "soon" cease functioning. Is there a plan in place to migrate to Manifest V3 and, if so, is there a workboard somewhere tracking the progress towards that goal? Browser extensions are well outside my bailiwick, but if PRs would be welcome related to accomplishing this, I'll put my money where my mouth is and do what I can to send them, provided I know I'm working on the right things. 😆

¹ This is truly a credit to the developers, because I was slow to warm to this extension when it rolled out some 4+ years ago, and now I'd be grieved to lose it from my workflow. Bravo, all.

alandtse commented 1 month ago

I'm not actively developing this at this point since I'm not doing too much in license compares myself these days, but will take PRs. I imagine it may be as simple as finding a new plugin template and copying it over.

Prasang023 commented 3 weeks ago

Hi @alandtse @RogueScholar I would like to work upon this issue. I'm following this: https://developer.chrome.com/docs/extensions/develop/migrate to fix this issue. I went through the code and this is what I think is required to be done:

This is just a initial estimate of things that I think I need to work upon to complete this task. Can you please let me know if I'm missing something.

alandtse commented 3 weeks ago

@Prasang023 That sounds like the right track but honestly I have no idea what's involved in manifest v3 so wouldn't be able to tell you. Best way to proceed it to go with your plan and see where it breaks and then hunt down help based on other plugins that made the transition and posted issues.

The other alternative may be to find a working v3 manifest template, copying that as a base, and then moving in the relevant code from here. There really isn't too much code in this plugin.