search

spdx / spdx-maven-plugin

Plugin for supporting SPDX in a Maven build.
Apache License 2.0
44 stars 26 forks source link

Document URI's not formatted correctly in RDF/XML format #138

Open goneall opened 11 months ago

goneall commented 11 months ago

For example, the generated document namespace for java-spdx-tagvalue-store version 1.6:

http://spdx.org/documents/java-spdx-tagvalue-store-%7B$version%7D

It should be:

http://spdx.org/documents/java-spdx-tagvalue-store-1.1.7
goneall commented 11 months ago

Note: the JSON format works fine

AniketNS commented 10 months ago

Hey @goneall, Assign this issue to me. I'd like to work on this.

goneall commented 10 months ago

Hey @goneall, Assign this issue to me. I'd like to work on this.

Hi @AniketNS , welcome to the project! Please feel free to take this issue. I'm currently traveling with limited access for the next 2 weeks. Once I'm back online I'll be able to assign the issue and answer any question you may have.

AniketNS commented 10 months ago

Sure @goneall, Thanks.

AniketNS commented 10 months ago

Hey @goneall, Am I supposed to make changes in the pom.xml file? Correct me If I'm wrong.

goneall commented 10 months ago

Hey @goneall, Am I supposed to make changes in the pom.xml file? Correct me If I'm wrong.

@AniketNS there's more to it. I can give you some background once I'm back from travels in about a week.

AniketNS commented 10 months ago

Sure @goneall.

goneall commented 9 months ago

@AniketNS - the fix will be in the code - around here: https://github.com/spdx/spdx-maven-plugin/blob/4bfcec8c9cac2ff667a190cf27929b9f1e99657b/src/main/java/org/spdx/maven/CreateSpdxMojo.java#L610C13-L610C13

or here: https://github.com/spdx/spdx-maven-plugin/blob/4bfcec8c9cac2ff667a190cf27929b9f1e99657b/src/main/java/org/spdx/maven/utils/SpdxDocumentBuilder.java#L145

I'd like to get this into a release I'm preparing - so let me know if you think you can get to this over the next couple of days, otherwise I'll take a stab at a fix.

goneall commented 9 months ago

I did a bit more looking and this is a bit of a challenging issue. Not sure why it only happens in the RDF XML format. Since it is only impacting RDF/XML and JSON is a much more popular format, I'm going to go ahead and postpone fixing this until the next release.

@AniketNS feel free to try and tackle this, but you may also find it quite a challenge to isolate the issue. Let me know if you're interested in looking into it.

AniketNS commented 9 months ago

Sorry @goneall, I don't think I can solve this issue. To my knowledge, I don't even know what is the problem here. So feel free to assign this issue to someone else.

goneall commented 9 months ago

Thanks @AniketNS for the reply.