search

spdx / spdx-spec

The SPDX specification in MarkDown and HTML formats.
https://spdx.github.io/spdx-spec/
Other
288 stars 137 forks source link

Add more detailed build instruction to README.md #932

Closed bact closed 5 months ago

bact commented 5 months ago

Add instruction on using spdx-3-model, spec-parser, and spdx-spec together.

This may allow more contributors to test the spec and spot issues early.

This PR is closed and two new separated PRs are opened instead:

goneall commented 5 months ago

Thanks @bact - One thing I noticed when I followed a similar build was that the generated files show up as modifications to the git directory for the spec.

I'm wondering if you saw the same and, if so, we should modify the .gitignore file to ignore those directories.

bact commented 5 months ago

Find similar thing. I just take this opportunity to add docs/model/ to .gitignore

bact commented 5 months ago

@goneall the generated files in ontology/ directory should also be considered for gitignore as well? (They are all outdated. Generated since February 2024)

bact commented 5 months ago

The GitHub validation workflow somehow doesn't start for this PR and several others.

bact commented 5 months ago

Looks like the workflow requires approval from a maintainer.

goneall commented 5 months ago

@bact - looks like there's some merge conflicts from some of our recent changes

bact commented 5 months ago

Thanks. Will check that.

Does it relate to my force push for DCO?

bact commented 5 months ago

"This branch cannot be rebased due to conflicts".

I will close this one and reopen new PRs.

bact commented 5 months ago

@goneall This PR is closed and splitting into 2 PRs instead: