Open bact opened 2 months ago
@licquia - could you do a quick review
@bact @licquia - note the related PR #934 - can we combine these into one PR?
@goneall @licquia Yes. If we don't plan to build docs for 3.0 again, I think it make sense to move over changes in this PR (publish_v3.yml and mkdocs.yml) to the PR #934, targeting 3.0.1.
@goneall Updated. Bring in changes for 3.0.1 by @licquia from PR #934 to here.
Thanks @bact - @licquia and/or @zvr - if you could do a quick review, we can merge
I'm not sure if we like to merge this at this time, since it has the tag latest
and if the workflow starts it will publish the unfinished v3.0.1
- which I don't think we like it like that.
Normally, latest
should point to the latest stable release, which is currently v3.0
.
See more thoughts on this in next comment.
I'm try to rethink and find what more logical is:
development/v3.0
branch, set checkout
to use 3.0
tag
publish_v3.yml
:
- uses: actions/checkout@f4...44 # v3
with:
repository: spdx/spdx-3-model
ref: 3.0
path: spdx-3-model
development/v3.0
branch, set latest
alias to point to v3.0
version
publish_v3.yml
:
run: mike deploy v3.0 latest -b gh-pages -p
development/v3.0
branch, set canonical_version
to latest
mkdocs.yml
:
- mike:
canonical_version: latest
development/v3.0
branch, run the publish workflow to have the proper latest on the current stable release (v3.0
)
development/v3.0.1
branch, set the version (for mkdocs) to v3.0.1-draft
(or v3.0.1-RCxxx
) (an alias can be added, if needed)
publish_v3.yml
:
run: mike deploy v3.0.1-draft -b gh-pages -p
main
branch (development branch)v3.0.1-draft
version (selectable from dropdown list in HTML)spdx-3-model
repo, release it using the tag 3.0.1
development/v3.0.1
branch, set checkout
to use 3.0.1
tag
publish_v3.yml
:
- uses: actions/checkout@f4...44 # v3
with:
repository: spdx/spdx-3-model
ref: 3.0.1
path: spdx-3-model
development/v3.0.1
branch, publish it with 3.0.1
version, with the alias latest
publish_v3.yml
:
run: mike deploy v3.0.1 latest -b gh-pages -p
development/v3.0.1
branch, set canonical_version
to latest
mkdocs.yml
:
- mike:
canonical_version: latest
development/v3.0.1
branch, run the publish workflow to have the proper latest on the current stable release (now v3.0.1
)If this is correct and agreed:
development/v3.0
branch. That new PR will be reviewed and merged before (4).--
Note: The content of (2)-(3) is PR #950 before the merge with #934 (this PR at the commit d44e0a6
) but it should be on development/v3.0
branch instead.
.github/workflows/publish_v3.yml
:alias
argument formike deploy
to havev3.0
as thelatest
v3.0
was aliased asv3-draft
, sov2.3
still occupied thelatest
alias.mkdocs.yml
:mike
section: Addcanonical_version
configuration aslatest
latest
appear near the first in search engine, among other versions, see https://github.com/jimporter/mike#configurationWill fix #949