Some optional fields are output in JSON even though they are optional

[lumjjb]

Through checking the output we noticed that a couple of fields were being output even though they are optional

• For example, the Package copyrightText field
• CreationInfo LicenseList field
• A few others that may need checking as well:
  • licenseConcluded,
  • licenseDeclared,
  • licenseInfoFromFiles,
  • packageVerificationCode

Reported on behalf on Google internal user (Amit).

[kzantow]

@lumjjb could you be more specific for the version(s) this affects? Some of these fields may have been made optional in 2.3, for example.

[lumjjb]

did some investigation

• Package copyrightText field (optional starting in 2.3 - PR#215 includes change)

  • 2.3: https://spdx.github.io/spdx-spec/v2.3/package-information/#717-copyright-text-field

• LicenseListFIeld field (optional - PR#215 includes change)

  • 2.3: https://spdx.github.io/spdx-spec/v2.3/document-creation-information/#67-license-list-version-field
  • 2.2: https://spdx.github.io/spdx-spec/v2.2.2/document-creation-information/#67-license-list-version-field
  • 2.1: Clause 2.7 in https://spdx.dev/spdx-specification-21-web-version/

• licenseConcluded, licenseDeclared, licenseInfoFromFiles implementation is correct, there was a change for them to no longer be required

• packageVerificationCode, looks like this is the same for 2.2 and 2.1 as it is for 2.3, 2.1 and 2.2 need to be updated (PR#215 includes change)

[lumjjb]

FIxed by #215