Standard exception should not require its text provided - Githubissues

spdx / tools

SPDX Tools

Apache License 2.0

126 stars 69 forks source link

Standard exception should not require its text provided #186

Closed grv87 closed 5 years ago

grv87 commented 5 years ago

The following code:

LicenseInfoFactory.parseSPDXLicenseString("GPL-2.0-only WITH Classpath-exception-2.0").verify();

returns validation error: Missing required license exception text.

Classpath-exception-2.0 exception is standard, from the list. So, it should not require its text provided.

goneall commented 5 years ago

@grv87 Thanks for reporting the error.

I researched the issue and the LicenseInfoFactory currently does not support listed SPDX exceptions and is not filling in the license text.

goneall commented 5 years ago

To resolve this issue, I would propose the following changes:

Add methods LicenseInfoFactory.isSPdxListedExceptionId(String exceptionId) and LicenseException LicenseInfoFactory.getListedExceptionById(String exceptionId)
Create a class ListedExceptions similar to the class ListedLicenses to handle the listed exceptions
Change the license parser WITH handling code to check for standard exceptions.

goneall commented 5 years ago

Since this is more than a couple hours work, I probably won't be able to fix this for a couple weeks. If anyone wants to create a pull request to resolve the issue, please do so - just assign the issue to yourself so we're not both working on it at the same time.

goneall commented 5 years ago

I started working on this issue and ran into another bug #187 . Once this is fixed and deployed, I'll complete the fix.

The work in progress is in the branch licenseexceptions.

goneall commented 5 years ago

Resolved with PR #189

@grv87 Let me know if you need a new release pushed to Maven Central

grv87 commented 5 years ago

@goneall, thanks a lot.

No rush for release. As a workaround I've set exception text manually before validation.