search

spdx / tools

SPDX Tools
Apache License 2.0
123 stars 68 forks source link

Added functionality for handling redirected links in ListedLicenses #233

Closed jay24rajput closed 4 years ago

jay24rajput commented 4 years ago

The original code would not redirect to the links, thus added a function that finds the redirected link and returns the same.

Fixes #219

goneall commented 4 years ago

@jay24rajput It looks like the .factory and .idea directories were added in your commit. Please update the .gitignore to ignore these files and update the PR to remove these files.

jay24rajput commented 4 years ago

@goneall I have deleted the required files, for the DCO checks I followed the commands listed in the debugging. An earlier commit got added to my list of commits due to the rebase.

Are there any more changes needed to be performed??

goneall commented 4 years ago

@jay24rajput It looks like the .factorypath is still showing up in the PR. If you could remove that.

Also, please add the spdx-tools.iml file since that is IDE specific. You can also add that to the .gitignore.

goneall commented 4 years ago

@jay24rajput Looks good - Thanks!