Avoid using deprecated Buffer constructor

spdy-http2 / http-deceiver

Deceive HTTP Parser

17 stars 8 forks source link

Avoid using deprecated Buffer constructor #5

Open ChALkeR opened 6 years ago

ChALkeR commented 6 years ago

Buffer.concat([]) returns an empty buffer all the way down to 0.8.x.

Alternative way would be to just use Buffer.alloc(0) and drop support for outdated Node.js versions.

Refs: https://nodejs.org/api/deprecations.html#deprecations_dep0005_buffer_constructor

Tracking: https://github.com/nodejs/node/issues/19079

ChALkeR commented 6 years ago

2018-02-26 deps list (top 10):

Query: "http-deceiver@
6428597 webpack-dev-server
4905488 spdy
4561130 http-deceiver
704705  react-scripts
346392  restify
171334  swagger-ui
162159  laravel-mix
105546  resolve-scripts
86959   react-styleguidist
62882   angular-cli

ChALkeR commented 6 years ago

Travis failure is probably unrelated, master is also failing.

lamweili commented 2 years ago

@indutny This should be merged as well, to patch all deprecation issues.

lamweili commented 2 years ago

cc: @jacobheun @daviddias @indutny