search

spdy-http2 / node-spdy

SPDY server on Node.js
2.81k stars 196 forks source link

I get error at 1.12.1 #112

Closed symplute closed 11 years ago

symplute commented 11 years ago

Hi. When I update to 1.12.1, I get error:

TypeError: Object #<Object> has no method 'write'
    at /mydir/node_modules/spdy/lib/spdy/connection.js:186:14
    at Framer.pingFrame (/mydir/node_modules/spdy/lib/spdy/protocol/framer.js:302:10)
    at Connection.handleFrame [as _handleFrame] (/mydir/node_modules/spdy/lib/spdy/connection.js:183:30)
    at Parser.EventEmitter.emit (events.js:95:17)
    at onFrame (/mydir/node_modules/spdy/lib/spdy/protocol/parser.js:222:12)
    at Parser.parseBody (/mydir/node_modules/spdy/lib/spdy/protocol/parser.js:278:5)
    at Parser.execute (/mydir/node_modules/spdy/lib/spdy/protocol/parser.js:216:12)
    at Parser.write [as _write] (/mydir/node_modules/spdy/lib/spdy/protocol/parser.js:121:8)
    at /mydir/node_modules/spdy/lib/spdy/protocol/parser.js:135:12
    at Parser.execute (/mydir/node_modules/spdy/lib/spdy/protocol/parser.js:201:5)

I think it use 'stream' instead of 'this' in callback at connection.js:185/186.

indutny commented 11 years ago

Thank you, fixed in 1.12.2.