search

spdy-http2 / node-spdy

SPDY server on Node.js
2.81k stars 196 forks source link

stream: _parseClientRequest should use non-greedy regex when parsing headers #132

Closed halvards closed 10 years ago

halvards commented 10 years ago

This pull request should fix a small bug in the client code. When splitting header name and value on colon, the regex should be non-greedy to prevent problems with header values that contain colons (the referer header in my example).

indutny commented 10 years ago

Very nice, thank you!

indutny commented 10 years ago

Landed https://github.com/indutny/node-spdy/commit/b31e59bcd3cfae4ffb9c6206d4961d59a9e6161f . Will release as soon as npm will go up :)

halvards commented 10 years ago

Thanks for the quick turnaround!