search

spdy-http2 / node-spdy

SPDY server on Node.js
2.81k stars 196 forks source link

max_concurrent of 0 in 1.29.0 #181

Closed mcmanus closed 9 years ago

mcmanus commented 9 years ago

1.29.0, when the server is given an options structure without a maxStreams member, sends a SETTINGS frame with MAX_CONCURRENT of 0 which I suspect is unintended.

1.28.1 given the same options sends MAX_CONCURRENT of 100 (the default).

var options = { key: fs.readFileSync(path.resolve(keysDir, 'spdy-key.pem')), cert: fs.readFileSync(path.resolve(keysDir, 'spdy-cert.pem')), ca: fs.readFileSync(path.resolve(keysDir, 'spdy-csr.pem')), rejectUnauthorized: false, };

var server = spdy.createServer(options);

indutny commented 9 years ago

Yeah, duplicate of #180 . Thanks for noticing it! Could you please try patch from #180?

mcmanus commented 9 years ago

that patch results in max concurrent not being in the settings frame (thus using the default). wfm. thanks

indutny commented 9 years ago

@mcmanus is there any default value?