search

spdy-http2 / node-spdy

SPDY server on Node.js
2.8k stars 196 forks source link

Fix for express compression module not activating #201

Closed hdf closed 9 years ago

hdf commented 9 years ago

Fix for Issues:

199

and expressjs/compression#38

indutny commented 9 years ago

Looks great, but what if we'll try to fit it somewhere here: https://github.com/indutny/node-spdy/blob/master/lib/spdy/stream.js#L52 ? I think you could use connection._spdyState.isServer && !state.associated as a condition for it.

Thank you!

hdf commented 9 years ago

Why would it be better there?

indutny commented 9 years ago

Because you won't need to hot-patch the req object and it will be properly built by the io.js/node.js core itself.

hdf commented 9 years ago

I have no idea, what that means, but I will try. :)