search

spdy-http2 / node-spdy

SPDY server on Node.js
2.8k stars 196 forks source link

If :status is already set, don't override it. #207

Closed jeffkaufman closed 8 years ago

jeffkaufman commented 9 years ago

Some code like https://www.igvita.com/2013/06/12/innovating-with-http-2.0-server-push/ sets headers[':status'] to give a custom status on server pushes, and unconditionally overriding headers[':status'] means you can't set it.

I'm not sure how to run the tests, so I haven't run them.

Fixes https://github.com/indutny/node-spdy/issues/206

indutny commented 8 years ago

May I ask you if this is better now? I have rewritten most of the stack in spdy-transport.

Thanks, and sorry for delay!