search

spdy-http2 / node-spdy

SPDY server on Node.js
2.81k stars 196 forks source link

Accept 'h2' as a connection protocol. #227

Closed rektide closed 8 years ago

rektide commented 8 years ago

Not sure if this is a problem or not.

Stepping through unit tests in jshttp/spdy-push, I noticed the incoming connection to the server was protocol 'h2' but server was only starting the connection for 'http2' and spdy strings.

indutny commented 8 years ago

It is rather odd! The server passes http2 explicitly here: https://github.com/indutny/node-spdy/blob/master/lib/spdy/server.js#L106 and same does client: https://github.com/indutny/node-spdy/blob/master/lib/spdy/agent.js#L125 .

Do you have a test case for this?

indutny commented 8 years ago

I guess this is not really an issue then. Thank you!