search

spdy-http2 / node-spdy

SPDY server on Node.js
2.81k stars 196 forks source link

isSpdy and spdyVersion are not set for res/OutgoingMessage #267

Closed webcarrot closed 7 years ago

webcarrot commented 7 years ago

README:

Request listener will receive two arguments: request and response. They're both instances of http's IncomingMessage and OutgoingMessage. But three custom properties are added to both of them: isSpdy, spdyVersion.

witch is not true... line 229

indutny commented 7 years ago

Yikes! This is definitely a bug. Does filing a PR to fix sound interesting you?

Thanks!

webcarrot commented 7 years ago

This is bug in code ... or in documentation - not my project and not my decision how to fix it.

PS. I prefer PR

indutny commented 7 years ago

Ah, that's right! Sorry to not mention it. I believe this is a bug in the code, not in the docs.

Please do not hesitate to ask me if you need any pointers or tips, I'll be more than happy to help!