search

spdy-http2 / node-spdy

SPDY server on Node.js
2.81k stars 196 forks source link

`spdy.maxStreams` unused? #286

Closed tony19 closed 7 years ago

tony19 commented 7 years ago

The README indicates an option to set max concurrent streams for server-push:

maxStreams - set "maximum concurrent streams" protocol option

But I found no reference to this option in the current code. It looks like it was actually removed in fa1e8cd (as part of #34). Are there plans to re-implement the option? Or is the option permanently removed (and the README out of date)?

anandsuresh commented 7 years ago

@tony19 The refactor you're referring to was made to modularize the code-base. All SPDY transport-specified code was moved into the spdy-transport npm module, which still supports the maxStreams option here.

Hope this helps.

tony19 commented 7 years ago

@anandsuresh Ah, yes. Thanks!