search

spdy-http2 / node-spdy

SPDY server on Node.js
2.81k stars 196 forks source link

Merge handle-thing 201 #365

Open cesarchefinho opened 4 years ago

cesarchefinho commented 4 years ago

use the new handle-thing 2.0.1 version in node-spdy to correct crash bug #350 under node >=11

RandomByte commented 4 years ago

Hey! node-spdy defines a range dependency to handle-thing: https://github.com/spdy-http2/node-spdy/blob/38c72152cd71ccd3b9e4218ef3408af3ec124717/package.json#L38

This means that, depending on how you are using node-spdy, all you need to do is updating your package-lock.json (assuming you have one) to install the latest version of handle-thing.

Simplest way:

rm package-lock.json
rm -rf node_modules
npm i
cesarchefinho commented 4 years ago

Can someone update this file package.json and change handle-things to 2.0.1 and commit ?

mir4ef commented 4 years ago

rather than removing the entire lock file, i would probably recommend npm update --depth=1 handle-thing