search

spdy-http2 / node-spdy

SPDY server on Node.js
2.81k stars 196 forks source link

(node:6332) [DEP0066] DeprecationWarning: OutgoingMessage.prototype._headers is deprecated #366

Open masx200 opened 4 years ago

masx200 commented 4 years ago

node -v v13.13.0

(node:6332) [DEP0066] DeprecationWarning: OutgoingMessage.prototype._headers is deprecated

https://github.com/spdy-http2/node-spdy/blob/661b14a8db40a76a9a4842fc12ca8908f989cfd9/lib/spdy/response.js#L18

  if (this._headers) {
FlorentinTh commented 4 years ago

I just made a pull request to fix it : #367

[EDIT] but obviously the CI fails on node 6 since the feature was introduced in version 7. If maintainers need to continue supporting node 6 maybe we will not have a release with the merge coming soon.

[EDIT-2] I was wrong in my first EDIT I found a way to support older versions of node.

masx200 commented 4 years ago

Support it. Great. Well done.

MatsG23 commented 4 years ago

I am also getting (node:12775) [DEP0066] DeprecationWarning: OutgoingMessage.prototype._headers is deprecated (Use node --trace-deprecation ... to show where the warning was created)

I'm using Node.js 14.1.0 and spdy 4.0.1

FlorentinTh commented 4 years ago

@MatsG23 yeah theoretically my pull request will fix all possible warnings however I cannot figure out how to make tests to work with node 12.x and 14.x. Moreover, the project seems to be left off since these newer versions of node include http2 and it is plan in the express 5 roadmap to support http2 which is currently not supported in v4.x

masx200 commented 4 years ago

@indutny @anandsuresh @eee-c @anandsuresh @daviddias

krishnaTORQUE commented 3 years ago

I am also getting the same warning 

(node:57156) [DEP0066] DeprecationWarning: OutgoingMessage.prototype._headers is deprecated
therealgilles commented 3 years ago

Any chance to get this fixed soon?

euberdeveloper commented 3 years ago

This deprecation warning was introduced I think with NodeJS 12 and I see that the npm module is last updated one year ago. Is this module dead?

sido420 commented 3 years ago

Any updates on this? These warnings are long and annoying