"Support node v0.8" actually broke it?

spdy-http2 / node-spdy

SPDY server on Node.js

2.81k stars 196 forks source link

"Support node v0.8" actually broke it? #77

Closed henrypijames closed 11 years ago

henrypijames commented 11 years ago

See igrigorik/node-spdyproxy#10

v1.3.9 was working fine with node v0.8, but v1.4.0 no long does. I don't know what that legacy test and DuplexStream thing is doing, but it looks like the prime suspect to me.

indutny commented 11 years ago

I've look on issue, spdyproxy was using some private methods like .lock and .unlock, they're all prefixed with underscore now. There're two choices either stick to 1.3.9, or stop using private methods, or use _lock and _unlock (probably more changes is needed in order to make it work).