search

spdy-http2 / spdy-transport

SPDY v2, v3, v3.1 and HTTP2 transport implementation for node.js
101 stars 37 forks source link

coverage directory contents inadvertently included with npm, please remove #45

Open cstrong opened 7 years ago

cstrong commented 7 years ago

spdy-transport npm includes a coverage directory that has a coverage.json file in it. This is somehow picked up by istanbul in other unrelated projects and it wreaks havoc. Let me know if I am missing anything, but I believe this problem exists in the latest release

cstrong commented 7 years ago

This is what I am getting in my project. I am still not sure exactly how this file gets picked up, perhaps a really sloppy regex?

`Error: ENOENT: no such file or directory, open '/Users/koruza/code/spdy-transport/lib/spdy-transport.js'

at Error (native)
at Object.fs.openSync (fs.js:640:18)
at Object.fs.readFileSync (fs.js:508:33)
at LookupStore.get (/usr/src/app/node_modules/istanbul/lib/store/fslookup.js:40:19)
at HtmlReport.writeDetailPage (/usr/src/app/node_modules/istanbul/lib/report/html.js:406:67)
at /usr/src/app/node_modules/istanbul/lib/report/html.js:484:26
at AsyncFileWriter.processFile (/usr/src/app/node_modules/istanbul/lib/util/file-writer.js:93:9)
at /usr/src/app/node_modules/async/lib/async.js:929:13
at Immediate.process (/usr/src/app/node_modules/async/lib/async.js:897:25)
at runCallback (timers.js:637:20)

Exited with code: 1. Warning: Task "exec:coverage:html:test/unit" failed. Use --force to continue.`

joshas commented 6 years ago

Issue still exists in latest release v2.0.20. It adds almost 1MB of unnecessary data to node_modules directory when spdy-transport package is included. Looks like fix was made here: https://github.com/spdy-http2/spdy-transport/pull/49