search

speakeasy-api / easytemplate

easytemplate is Go's text/template with 🦸 JS super powers 🦸
https://pkg.go.dev/github.com/speakeasy-api/easytemplate
Apache License 2.0
47 stars 2 forks source link

README.md typo for tmpl2.stmpl #6

Closed dpankros closed 1 year ago

dpankros commented 1 year ago

In README.md there is an error in the content of the example tmpl2.stmpl. {{ .SomeComputedText }} should be: {{ .Local.SomeComputedText }}

Feel free to reproduce with my test repo.

I have a trivial PR ready for your convenience, if you're interested.

The reproduction repo also adds javascript console statement that directs the user to look at the out.txt file in the root of the project to see the rendered output. While it should be obvious, it wasn't to me (or I overlooked it) and I wasted a couple minutes wondering where the rest of the output was.

TristanSpeakEasy commented 1 year ago

Please feel free to open a PR otherwise I’ll look to fix the issue as soon as I can, thank you for finding the issue 🙏

dpankros commented 1 year ago

@TristanSpeakEasy There was an issue in README.md/main.go that I forgot about. I'm going to send another PR your way to address it. I didn't think it really warranted another open issue for my mistake.

TristanSpeakEasy commented 1 year ago

Absolutely no problem thanks again for finding these

dpankros commented 1 year ago

Happy to help!