search

speakeasyjs / speakeasy

**NOT MAINTAINED** Two-factor authentication for Node.js. One-time passcode generator (HOTP/TOTP) with support for Google Authenticator.
MIT License
2.71k stars 229 forks source link

urls generated by speakeasy.otpauthURL do not include counter in query string if provided #61

Closed railsstudent closed 7 years ago

railsstudent commented 7 years ago

if otp type is hotp and counter is provided, the value of counter is not appended to query string.

mikepb commented 7 years ago

How could we test the HOTP counter URL parameter? Could you provide a test case?

On Dec 22, 2016, at 7:39 AM, Connie Leung notifications@github.com wrote:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/speakeasyjs/speakeasy/issues/61, or mute the thread https://github.com/notifications/unsubscribe-auth/AAm4b4QXE1qxR3Ui6M0gVjBXfyx_eZRvks5rKpmjgaJpZM4LUGGs.

railsstudent commented 7 years ago

I submitted a pull request that includes two test cases.