search

speakeasyjs / speakeasy

**NOT MAINTAINED** Two-factor authentication for Node.js. One-time passcode generator (HOTP/TOTP) with support for Google Authenticator.
MIT License
2.7k stars 228 forks source link

Fix "Error using base32 encoding #64" #66

Closed railsstudent closed 7 years ago

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling d166c6e9dc93df50ed5ce7f002f0740fdd611880 on railsstudent:master into 2b3b947e08f198fb6133546b17a594f0df93a8da on speakeasyjs:master.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling d166c6e9dc93df50ed5ce7f002f0740fdd611880 on railsstudent:master into 2b3b947e08f198fb6133546b17a594f0df93a8da on speakeasyjs:master.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling d166c6e9dc93df50ed5ce7f002f0740fdd611880 on railsstudent:master into 2b3b947e08f198fb6133546b17a594f0df93a8da on speakeasyjs:master.

mikepb commented 7 years ago

Test case?

railsstudent commented 7 years ago

What kind of test cases are needed? I can write test cases that don't throw error, however, I don't have actual inputs to validate digest returned is correct.

mikepb commented 7 years ago

The test case is running Speakeasy in the browser. I wrote base32 to return a native JavaScript Array instead of a Node Buffer, hence issue #64

Speakeasy doesn't officially support the browser, so I would consider this a temporary hotfix in lieu of implementing a more major enhancement.