search

speakeasyjs / speakeasy

**NOT MAINTAINED** Two-factor authentication for Node.js. One-time passcode generator (HOTP/TOTP) with support for Google Authenticator.
MIT License
2.71k stars 229 forks source link

Default values of otpAuthURL are inconsistent with the documentation in README.md #71

Closed railsstudent closed 7 years ago

railsstudent commented 7 years ago

In README.md, the default values of algorithm, digits, period are sha1, 6 and 30 respectively. In code, no value is assigned and it works in google authenticator app for now because these parameters are ignored.

In code, the default value of encoding is ascii but README.md leaves the default value blank, I would like to make the doc and code consistent, so the code does what the documentation says.

markbao commented 7 years ago

@railsstudent, PR #74 resolves this, correct?

Sharp eye - thanks for being on top of this.

railsstudent commented 7 years ago

yes. #74 resolves this.

mikepb commented 7 years ago

Closing as resolved.