search

speakeasyjs / speakeasy

**NOT MAINTAINED** Two-factor authentication for Node.js. One-time passcode generator (HOTP/TOTP) with support for Google Authenticator.
MIT License
2.71k stars 229 forks source link

Run Standard formatter prior to releasing 3.0 #78

Closed mikepb closed 7 years ago

mikepb commented 7 years ago

Use standard to format source code, require all future updates to use standard format. Reduces chances of superfluous code changes, such as white-space, slowing down the review process.

markbao commented 7 years ago

Should we have a GitHub PR check for Standard linting?

Also, we're using Semistandard (Standard + semicolons), not sure if there's any interest in changing it.

mikepb commented 7 years ago

I didn’t that was a thing! Semistandard linting would work.

On Feb 9, 2017, at 8:01 PM, Mark Bao notifications@github.com wrote:

Should we have a GitHub PR check for Standard linting?

Also, we're using Semistandard (Standard + semicolons), not sure if there's any interest in changing it.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/speakeasyjs/speakeasy/issues/78#issuecomment-278852043, or mute the thread https://github.com/notifications/unsubscribe-auth/AAm4b0XNdNDo0O1aZX4mDaPNzrfoYv4Vks5ra-EcgaJpZM4L85cP.

markbao commented 7 years ago

Sounds good. I made sure our 2.0 release passed Semistandard, but likely not the code since.