Open zellidev0 opened 1 year ago
In the option.dart file a comment suggests that the code below the comment has side effects.
option.dart
// PURISTS BEWARE: side effecty stuff below -- proceed with caution!
One Method there is the toNullable() method.
toNullable()
It looks like that:
A? toNullable() => fold(() => null, id);
This method does not seem to create a side effect and therefore it should be above the stated comment to avoid confusion.
I would create a PR that moves the method upwords, so that it is above the comment. Would this PR be merged?
In the
option.dartfile a comment suggests that the code below the comment has side effects.// PURISTS BEWARE: side effecty stuff below -- proceed with caution!One Method there is the
toNullable()method.It looks like that:
This method does not seem to create a side effect and therefore it should be above the stated comment to avoid confusion.
I would create a PR that moves the method upwords, so that it is above the comment. Would this PR be merged?